• Tim van der Lippe's avatar
    Revert "[inspector] Use side-effect free debug evaluate for inherited accessors." · e9d36117
    Tim van der Lippe authored
    This reverts commit f9ebad01.
    
    Reason for revert: suspected root cause of crbug.com/1257806 Additionally, this patch might actually be incorrect as we eagerly evaluate native accessors, which can only happen if the debugger is running.
    
    Original change's description:
    > [inspector] Use side-effect free debug evaluate for inherited accessors.
    >
    > Replace the hard-coded blocklist ("Response.body" and "Request.body") in
    > the V8 inspector with proper side-effect free debug evaluate. This is
    > otherwise a non-functional change and in particular preserves the
    > behavior of reporting accessors as (own) data properties. That will be
    > tackled in a follow-up CL.
    >
    > This CL is possible because with https://crrev.com/c/3056879 Blink now
    > properly marks accessors as side-effect free consistently with what the
    > V8 inspector had done before.
    >
    > Doc: http://doc/1gLyyOlssS5zyCSEyybVC-5sp0UnNJj2hBoFyf6ryrTc
    > Bug: chromium:829571, chromium:1076820, chromium:1119900
    > Change-Id: Idb256accaf4cfb5db5982b3eb06ddcef588be635
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062573
    > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
    > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76019}
    
    Bug: chromium:829571, chromium:1076820, chromium:1119900, chromium:1257806
    Fixed: chromium:1265372
    Change-Id: Ia31a3022aaa9ddeae1f01eaa90e345f8bdbb21c9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259653
    Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77708}
    e9d36117
Name
Last commit
Last update
..
add-binding-expected.txt Loading commit data...
add-binding.js Loading commit data...
await-promise-expected.txt Loading commit data...
await-promise.js Loading commit data...
call-function-on-async-expected.txt Loading commit data...
call-function-on-async.js Loading commit data...
call-function-on-side-effect-free-expected.txt Loading commit data...
call-function-on-side-effect-free.js Loading commit data...
clear-of-command-line-api-expected.txt Loading commit data...
clear-of-command-line-api.js Loading commit data...
client-console-api-message-expected.txt Loading commit data...
client-console-api-message.js Loading commit data...
command-line-api-expected.txt Loading commit data...
command-line-api-without-side-effects-expected.txt Loading commit data...
command-line-api-without-side-effects.js Loading commit data...
command-line-api.js Loading commit data...
compile-script-expected.txt Loading commit data...
compile-script.js Loading commit data...
console-api-repeated-in-console-expected.txt Loading commit data...
console-api-repeated-in-console.js Loading commit data...
console-assert-expected.txt Loading commit data...
console-assert.js Loading commit data...
console-context-expected.txt Loading commit data...
console-context.js Loading commit data...
console-line-and-column-expected.txt Loading commit data...
console-line-and-column.js Loading commit data...
console-log-doesnt-run-microtasks-expected.txt Loading commit data...
console-log-doesnt-run-microtasks.js Loading commit data...
console-memory-expected.txt Loading commit data...
console-memory.js Loading commit data...
console-message-omit-data-urls-expected.txt Loading commit data...
console-message-omit-data-urls.js Loading commit data...
console-messages-limits-expected.txt Loading commit data...
console-messages-limits.js Loading commit data...
console-methods-expected.txt Loading commit data...
console-methods.js Loading commit data...
console-spec-expected.txt Loading commit data...
console-spec.js Loading commit data...
console-table-expected.txt Loading commit data...
console-table.js Loading commit data...
console-time-end-format-expected.txt Loading commit data...
console-time-end-format.js Loading commit data...
console-time-log-expected.txt Loading commit data...
console-time-log.js Loading commit data...
console-time-repeat-expected.txt Loading commit data...
console-time-repeat.js Loading commit data...
console-timestamp-expected.txt Loading commit data...
console-timestamp.js Loading commit data...
context-destroyed-on-context-collected-expected.txt Loading commit data...
context-destroyed-on-context-collected.js Loading commit data...
create-context-expected.txt Loading commit data...
create-context.js Loading commit data...
custom-preview-expected.txt Loading commit data...
custom-preview.js Loading commit data...
enable-async-stack-expected.txt Loading commit data...
enable-async-stack.js Loading commit data...
error-preview-expected.txt Loading commit data...
error-preview.js Loading commit data...
es6-module-expected.txt Loading commit data...
es6-module.js Loading commit data...
evaluate-async-expected.txt Loading commit data...
evaluate-async-with-wrap-error-expected.txt Loading commit data...
evaluate-async-with-wrap-error.js Loading commit data...
evaluate-async.js Loading commit data...
evaluate-empty-stack-expected.txt Loading commit data...
evaluate-empty-stack.js Loading commit data...
evaluate-new-function-error-expected.txt Loading commit data...
evaluate-new-function-error.js Loading commit data...
evaluate-repl-await-expected.txt Loading commit data...
evaluate-repl-await.js Loading commit data...
evaluate-repl-mode-code-cache-expected.txt Loading commit data...
evaluate-repl-mode-code-cache.js Loading commit data...
evaluate-repl-mode-expected.txt Loading commit data...
evaluate-repl-mode-side-effecting-expected.txt Loading commit data...
evaluate-repl-mode-side-effecting.js Loading commit data...
evaluate-repl-mode.js Loading commit data...
evaluate-run-microtasks-expected.txt Loading commit data...
evaluate-run-microtasks.js Loading commit data...
evaluate-timeout-expected.txt Loading commit data...
evaluate-timeout.js Loading commit data...
evaluate-unique-context-id-expected.txt Loading commit data...
evaluate-unique-context-id.js Loading commit data...
evaluate-unserializable-expected.txt Loading commit data...
evaluate-unserializable.js Loading commit data...
evaluate-with-context-id-equal-zero-expected.txt Loading commit data...
evaluate-with-context-id-equal-zero.js Loading commit data...
evaluate-with-disable-breaks-expected.txt Loading commit data...
evaluate-with-disable-breaks.js Loading commit data...
evaluate-with-generate-preview-expected.txt Loading commit data...
evaluate-with-generate-preview.js Loading commit data...
evaluate-without-side-effects-expected.txt Loading commit data...
evaluate-without-side-effects-i18n-expected.txt Loading commit data...
evaluate-without-side-effects-i18n.js Loading commit data...
evaluate-without-side-effects.js Loading commit data...
exception-thrown-expected.txt Loading commit data...
exception-thrown-metadata-expected.txt Loading commit data...
exception-thrown-metadata.js Loading commit data...
exception-thrown.js Loading commit data...
exceptionthrown-on-connect-expected.txt Loading commit data...
exceptionthrown-on-connect.js Loading commit data...
function-location-expected.txt Loading commit data...
function-location.js Loading commit data...
function-scopes-expected.txt Loading commit data...
function-scopes.js Loading commit data...
get-heap-usage-expected.txt Loading commit data...
get-heap-usage.js Loading commit data...
get-isolate-id-expected.txt Loading commit data...
get-isolate-id.js Loading commit data...
get-properties-expected.txt Loading commit data...
get-properties-on-proxy-expected.txt Loading commit data...
get-properties-on-proxy.js Loading commit data...
get-properties-preview-expected.txt Loading commit data...
get-properties-preview.js Loading commit data...
get-properties.js Loading commit data...
internal-properties-entries-expected.txt Loading commit data...
internal-properties-entries.js Loading commit data...
internal-properties-expected.txt Loading commit data...
internal-properties.js Loading commit data...
length-or-size-description-expected.txt Loading commit data...
length-or-size-description.js Loading commit data...
property-on-console-proto-expected.txt Loading commit data...
property-on-console-proto.js Loading commit data...
protocol-works-with-different-locale-expected.txt Loading commit data...
protocol-works-with-different-locale.js Loading commit data...
query-objects-expected.txt Loading commit data...
query-objects.js Loading commit data...
regress-1075763-expected.txt Loading commit data...
regress-1075763.js Loading commit data...
regress-1078205-expected.txt Loading commit data...
regress-1078205.js Loading commit data...
regress-986051-expected.txt Loading commit data...
regress-986051.js Loading commit data...
regression-1052721-expected.txt Loading commit data...
regression-1052721.js Loading commit data...
regression-1140845-expected.txt Loading commit data...
regression-1140845.js Loading commit data...
regression-732717-expected.txt Loading commit data...
regression-732717.js Loading commit data...
regression-736302-expected.txt Loading commit data...
regression-736302.js Loading commit data...
release-object-expected.txt Loading commit data...
release-object.js Loading commit data...
remote-object-expected.txt Loading commit data...
remote-object-get-properties-expected.txt Loading commit data...
remote-object-get-properties.js Loading commit data...
remote-object.js Loading commit data...
run-script-async-expected.txt Loading commit data...
run-script-async.js Loading commit data...
runtime-disable-preserve-injected-script-expected.txt Loading commit data...
runtime-disable-preserve-injected-script.js Loading commit data...
runtime-evaluate-null-property-expected.txt Loading commit data...
runtime-evaluate-null-property.js Loading commit data...
runtime-evaluate-with-dirty-context-expected.txt Loading commit data...
runtime-evaluate-with-dirty-context.js Loading commit data...
runtime-get-properties-and-accessor-expected.txt Loading commit data...
runtime-get-properties-and-accessor.js Loading commit data...
runtime-global-lexical-scope-names-expected.txt Loading commit data...
runtime-global-lexical-scope-names.js Loading commit data...
runtime-restore-expected.txt Loading commit data...
runtime-restore.js Loading commit data...
set-max-call-stack-size-expected.txt Loading commit data...
set-max-call-stack-size.js Loading commit data...
set-or-map-entries-expected.txt Loading commit data...
set-or-map-entries.js Loading commit data...
terminate-execution-expected.txt Loading commit data...
terminate-execution.js Loading commit data...