• Jakob Gruber's avatar
    [regexp] Pass correct limit to Runtime::kRegExpSplit · c7a7bf6a
    Jakob Gruber authored
    The Uint32(limit) conversion can end up transitioning the regexp
    instance to slow mode. In this case we need to bail out to runtime while
    ensuring that ToUint32 is not observably called a second time. We do
    this by passing the already-converted value to runtime.
    
    This particular path was broken and we ended up passing the original
    maybe_limit value to runtime instead.
    
    TBR=yangguo@chromium.org
    
    Bug: chromium:758763
    Change-Id: If7f23b452d2e134ad9be3d4ef1d78d1c946fcef0
    Reviewed-on: https://chromium-review.googlesource.com/635588Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47609}
    c7a7bf6a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...