• Leszek Swirski's avatar
    [turbofan] DCHECK that lookups have a slow path · c6a8832e
    Leszek Swirski authored
    LdaLookupGlobal/ContextSlot loop over parent contexts to check for
    context extensions. If there aren't any, they can do a fast
    context/global load, otherwise they have to call a runtime slow path.
    
    The bytecode graph builder didn't build a slow path in the case where no
    context extensions are possible, by depth == 0 or static scope info
    information that there are no possible context extensions. However, this
    information is already known to the interpreter, so that should already
    elide the lookup in these cases. So, get rid of the slow path being
    optional in TurboFan, and consider such cases bytecode generation bugs.
    
    Change-Id: Ib69f90e51b0f783306824fed56911d039f7e134e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872277
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82972}
    c6a8832e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...