• Bill Budge's avatar
    Revert "Revert "[debugger] do not try to find saved context before DebugEvaluate::Local"" · 781fa726
    Bill Budge authored
    This reverts commit 2a8e1e4a.
    
    Reason for revert: Time outs were caused by infra issues.
    
    Original change's description:
    > Revert "[debugger] do not try to find saved context before DebugEvaluate::Local"
    > 
    > This reverts commit ea7499df.
    > 
    > Reason for revert: Speculative, but this CL seems correlated with a bunch of timeouts on Linux:
    > 
    > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/19540
    > 
    > Original change's description:
    > > [debugger] do not try to find saved context before DebugEvaluate::Local
    > > 
    > > Current implementation produces crashes since sometimes saved context
    > > is empty. It looks like we do not need to restore saved context since
    > > we do not set debug context as current, at least all tests are passed.
    > > 
    > > R=​yangguo@chromium.org
    > > 
    > > Bug: chromium:797573,chromium:792838
    > > Change-Id: I1271640f6a18cbaaecfa1e99ed9ac28e0dbbb1da
    > > Reviewed-on: https://chromium-review.googlesource.com/844979
    > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#50327}
    > 
    > TBR=yangguo@chromium.org,kozyatinskiy@chromium.org
    > 
    > Change-Id: I543201698c96c9762c481c1f6012cc13cb712842
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: chromium:797573, chromium:792838
    > Reviewed-on: https://chromium-review.googlesource.com/846205
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Commit-Queue: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50331}
    
    TBR=bbudge@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
    
    Change-Id: I44e916c796b935c372ce418a3fad44aa25d6f863
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:797573, chromium:792838
    Reviewed-on: https://chromium-review.googlesource.com/848132Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50332}
    781fa726
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
debug.js Loading commit data...
interface-types.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...
liveedit.js Loading commit data...
mirrors.js Loading commit data...