• Clemens Backes's avatar
    Revert "[wasm] Do memory.init bounds check in C++ code" · c5cecf8d
    Clemens Backes authored
    This reverts commit c7a26b13.
    
    Reason for revert: Need to revert previous CL because it fails on MSVC: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/12805
    
    Original change's description:
    > [wasm] Do memory.init bounds check in C++ code
    > 
    > In the existing implementation we first did a bounds check in generated
    > code, and then called a simple C++ function to do the actual copying.
    > With this CL now we pass the WasmInstanceObject to the C++ function in
    > addition to the memory.init parameters. Thereby we can do the bounds
    > check in C++, which is much easier, less error prone, and which also
    > speeds up code generation and reduces code size. Performance should not
    > be worse, because we were already doing the call to C++ anyways.
    > 
    > R=​clemensb@chromium.org
    > 
    > Bug: v8:10281
    > Change-Id: Ia86e1d08001a8bc7556277abeaa9208ec1128f89
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2096621
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66656}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: I1064113e7f1c445d04652a973c994317fd3e739a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10281
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2096624Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66657}
    c5cecf8d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...