• Benedikt Meurer's avatar
    Revert "[inspector] Fix `Runtime.setMaxCallStackSizeToCapture`." · c51b582d
    Benedikt Meurer authored
    This reverts commit 34f73cc7.
    
    Reason for revert: Performance regressions throughout a lot of
    system health and browsing benchmarks.
    
    Original change's description:
    > [inspector] Fix `Runtime.setMaxCallStackSizeToCapture`.
    >
    > This change fixes the implementation of the previously introduced API
    > `Runtime.setMaxCallStackSizeToCapture` to work correctly and also apply
    > (consistently) to stack traces captured by V8 when exceptions are
    > thrown. It does so in a fully backwards compatible manner.
    >
    > This change thus makes the previous fix for catapult (which landed in
    > http://crrev.com/c/3347789) effective, and therefore ensures that real
    > world performance benchmarks aren't affected by the use of the `Runtime`
    > domain in the catapult test framework.
    >
    > Bug: chromium:1283162, chromium:1278650, chromium:1258599
    > Bug: chromium:1280803, chromium:1280832, chromium:1280818
    > Fixed: chromium:1280831
    > Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    > Change-Id: I4ec951a858317fa49096cd4023deb0104d92c9c9
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361839
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78458}
    
    Bug: chromium:1283162, chromium:1278650, chromium:1258599
    Bug: chromium:1280803, chromium:1280832, chromium:1280818
    Bug: chromium:1280831
    Change-Id: Id1efaffa2f7f08c47f833f68b8a297494edee21e
    Fixed: chromium:1283751, chromium:1283749, chromium:1283746
    Fixed: chromium:1283729, chromium:1283700, chromium:1283700
    Fixed: chromium:1283691, chromium:1283687, chromium:1283678
    Fixed: chromium:1283677, chromium:1283676, chromium:1283675
    Fixed: chromium:1283674, chromium:1283618, chromium:1283536
    Fixed: chromium:1283523, chromium:1283516
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364078
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78462}
    c51b582d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...