• Thibaud Michaud's avatar
    [regalloc] Fix slot requirement for live ranges defined by a const · 0ee6f90a
    Thibaud Michaud authored
    Live ranges defined by a constant operand normally don't require a spill
    slot since they can just rematerialize the value from the constant. In
    the attached issue however, deoptimization adds an explicit slot
    requirement for a range that is defined by a constant operand. This case
    is not expected in the register allocator and we eventually hit a
    DCHECK.
    
    This fix allocates a new stack slot during the MeetRegisterConstraints
    and adds the missing gap move.
    
    Drive-by: remove dead method LiveRange::NextSlotPosition.
    
    R=sigurds@chromium.org
    CC=​nicohartmann@chromium.org
    
    Bug: chromium:1146880
    Change-Id: I08fbb890f2f3d9574196989cf3e5ef6232433484
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563689Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73510}
    0ee6f90a
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
mid-tier-register-allocator.cc Loading commit data...
mid-tier-register-allocator.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
register-allocation.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
spill-placer.cc Loading commit data...
spill-placer.h Loading commit data...
unwinding-info-writer.h Loading commit data...