• Andreas Haas's avatar
    [wasm] Do memory.copy bounds check in C++ code · c475e704
    Andreas Haas authored
    In the existing implementation we first did a bounds check in generated
    code, and then called a simple C++ function to do the actual copying.
    With this CL now we pass the WasmInstanceObject to the C++ function in
    addition to the memory.copy parameters. Thereby we can do the bounds
    check in C++, which is much easier, less error prone, and which also
    speeds up code generation and reduces code size. Performance should not
    be worse, because we were already doing the call to C++ anyways.
    
    R=clemensb@chromium.org
    
    Bug: v8:10281
    Change-Id: I24488d92056f0b5df27a61783a274895bd37cc24
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093434
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66655}
    c475e704
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...