• Maya Lekova's avatar
    Revert "cppgc: Rework GC info creation" · 8b9d0138
    Maya Lekova authored
    This reverts commit d76064df.
    
    Reason for revert: Breaking MSAN - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/37390/overview
    
    Original change's description:
    > cppgc: Rework GC info creation
    >
    > Previously, GCInfoTrait relied on the non-trivial constructor of a
    > static object for registering a new GCInfo object. The generated code
    > is required to be thread-safe which is achieved by introducing guard
    > variables in the compiler.
    >
    > The new version is similar to Blink in that it relies on zero
    > initialization of a trivially constructible atomic.
    >
    > Compared to guard variables that are created per GCInfo registration,
    > the atomic creates less bloat (~20bytes/type) and also results in a
    > better fast path.
    >
    > Minimum example: https://godbolt.org/z/qrdTf8
    >
    > Bug: chromium:1056170
    > Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73463}
    
    Bug: chromium:1056170
    Change-Id: I71960103513d6db7789d752b70727d014c2e6406
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767020
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73466}
    8b9d0138
Name
Last commit
Last update
..
allocation.cc Loading commit data...
caged-heap-local-data.cc Loading commit data...
caged-heap.cc Loading commit data...
caged-heap.h Loading commit data...
compaction-worklists.cc Loading commit data...
compaction-worklists.h Loading commit data...
compactor.cc Loading commit data...
compactor.h Loading commit data...
concurrent-marker.cc Loading commit data...
concurrent-marker.h Loading commit data...
default-platform.cc Loading commit data...
explicit-management.cc Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
garbage-collector.h Loading commit data...
gc-info-table.cc Loading commit data...
gc-info-table.h Loading commit data...
gc-info.cc Loading commit data...
gc-invoker.cc Loading commit data...
gc-invoker.h Loading commit data...
globals.h Loading commit data...
heap-base.cc Loading commit data...
heap-base.h Loading commit data...
heap-consistency.cc Loading commit data...
heap-growing.cc Loading commit data...
heap-growing.h Loading commit data...
heap-object-header.cc Loading commit data...
heap-object-header.h Loading commit data...
heap-page.cc Loading commit data...
heap-page.h Loading commit data...
heap-space.cc Loading commit data...
heap-space.h Loading commit data...
heap-state.cc Loading commit data...
heap-statistics-collector.cc Loading commit data...
heap-statistics-collector.h Loading commit data...
heap-visitor.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-schedule.cc Loading commit data...
incremental-marking-schedule.h Loading commit data...
liveness-broker.cc Loading commit data...
liveness-broker.h Loading commit data...
logging.cc Loading commit data...
marker.cc Loading commit data...
marker.h Loading commit data...
marking-state.cc Loading commit data...
marking-state.h Loading commit data...
marking-verifier.cc Loading commit data...
marking-verifier.h Loading commit data...
marking-visitor.cc Loading commit data...
marking-visitor.h Loading commit data...
marking-worklists.cc Loading commit data...
marking-worklists.h Loading commit data...
metric-recorder.h Loading commit data...
name-trait.cc Loading commit data...
object-allocator.cc Loading commit data...
object-allocator.h Loading commit data...
object-poisoner.h Loading commit data...
object-size-trait.cc Loading commit data...
object-start-bitmap.h Loading commit data...
page-memory.cc Loading commit data...
page-memory.h Loading commit data...
persistent-node.cc Loading commit data...
platform.cc Loading commit data...
pointer-policies.cc Loading commit data...
prefinalizer-handler.cc Loading commit data...
prefinalizer-handler.h Loading commit data...
process-heap-statistics.cc Loading commit data...
process-heap-statistics.h Loading commit data...
process-heap.cc Loading commit data...
process-heap.h Loading commit data...
raw-heap.cc Loading commit data...
raw-heap.h Loading commit data...
sanitizers.h Loading commit data...
source-location.cc Loading commit data...
stats-collector.cc Loading commit data...
stats-collector.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
task-handle.h Loading commit data...
testing.cc Loading commit data...
trace-event.h Loading commit data...
trace-trait.cc Loading commit data...
virtual-memory.cc Loading commit data...
virtual-memory.h Loading commit data...
visitor.cc Loading commit data...
visitor.h Loading commit data...
write-barrier.cc Loading commit data...
write-barrier.h Loading commit data...