• mbrandy's avatar
    PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. · c1507e15
    mbrandy authored
    Port d00da47b
    
    Original commit message:
        The CompareICStub produces an untagged raw word value, which has to be
        translated to true or false manually in the TurboFan code. But for lazy
        bailout after the CompareIC, we immediately go back to fullcodegen or
        Ignition with the raw value, to a location where both fullcodegen and
        Ignition expect a boolean value, which might crash or in the worst case
        (depending on the exact computation inside the CompareIC) could lead to
        arbitrary memory access.
    
        Short-term fix is to use the proper runtime functions (unified with the
        interpreter now) for comparisons. Next task is to provide optimized
        versions of these based on the CodeStubAssembler, which can then be used
        via code stubs in TurboFan or directly in handlers in the interpreter.
    
    R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=v8:4788
    LOG=n
    
    Review URL: https://codereview.chromium.org/1745643002
    
    Cr-Commit-Position: refs/heads/master@{#34341}
    c1507e15
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...