• Sathya Gunasekaran's avatar
    Revert "Reland "[test][d8] Add d8.log.getAndStop helper"" · 92236da2
    Sathya Gunasekaran authored
    This reverts commit 23531d82.
    
    Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/33007?
    
    Original change's description:
    > Reland "[test][d8] Add d8.log.getAndStop helper"
    > 
    > This is a reland of 95aa697b
    > 
    > Original change's description:
    > > [test][d8] Add d8.log.getAndStop helper
    > >
    > > The new helper function allows us to write tests for log parsing
    > > without the need to first generating a log file. This makes it easier
    > > to spot errors when the log format changes.
    > >
    > > - Add d8 global variable
    > > - Add file_name accessor to Logger and Log classes
    > > - Change OS::LogFileOpenMode to w+ / wb+
    > > - Use separate Log::WriteLogHeader method
    > > - Remove unused logger_ instance variable from Log
    > >
    > > Bug: v8:10644
    > > Change-Id: Ifc7e35aa4e91b3f01f0847843263946e085944c3
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387563
    > > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#69715}
    > 
    > Bug: v8:10644
    > 
    > TBR=verwaest@chromium.org
    > 
    > Change-Id: I54741344834d88a376b74e2e3a2047e880a94624
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2396081
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69769}
    
    TBR=mlippautz@chromium.org,cbruni@chromium.org,gsathya@chromium.org,verwaest@chromium.org
    
    Change-Id: I493315e0d6498f0fa9bed3409725bb52d554b53a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10644
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400982Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69770}
    92236da2
Name
Last commit
Last update
..
OWNERS Loading commit data...
code-events.h Loading commit data...
counters-definitions.h Loading commit data...
counters-inl.h Loading commit data...
counters.cc Loading commit data...
counters.h Loading commit data...
local-logger.cc Loading commit data...
local-logger.h Loading commit data...
log-inl.h Loading commit data...
log-utils.cc Loading commit data...
log-utils.h Loading commit data...
log.cc Loading commit data...
log.h Loading commit data...
metrics.cc Loading commit data...
metrics.h Loading commit data...
tracing-flags.cc Loading commit data...
tracing-flags.h Loading commit data...