• Benedikt Meurer's avatar
    [wasm][debug] Expose instance and module instead of imports / exports. · ad42f966
    Benedikt Meurer authored
    The "imports" and "exports" that were exposed on WebAssembly frames via
    Debug-Evaluate aren't useful for the DWARF C/C++ extension (and likely
    not for any other language extension), since they only expose static
    information that's easily available (upfront) by reading the Wasm wire
    bytes.
    
    In fact, there are already standardized functions in the WebAssembly
    specification, namely `WebAssembly.Module.imports(module)` and
    `WebAssembly.Module.exports(module)`, which yield static information
    about the imports and exports of a Wasm module.
    
    So instead of exposing special, non-standard "imports" and "exports", we
    now instead expose both the "instance" and the "module" objects via both
    the Debug Proxy and the Scope view, and also add internal [[Exports]]
    and [[Imports]] properties to WasmModuleObject, which under the hood use
    the standard methods mentioned above.
    
    Fixed: chromium:1162069
    Bug: chromium:1071432, chromium:1083146
    Screenshot: https://imgur.com/lcaW2jL.png
    Doc: https://docs.google.com/document/d/1rqbu0jKTl3q_xCxLnKzkjGXWEsHnJ9aERVhKV9RNDgE#bookmark=id.925bb2qgou38
    Change-Id: Ie27e55bb08ea5f90493c57375bf2b48dfb11a4d2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606050
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71893}
    ad42f966
Name
Last commit
Last update
..
console Loading commit data...
counters Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...