• Dan Elphick's avatar
    Reland "Reland "[compiler] Don't collect source positions for the top frame"" · bf9e3e4d
    Dan Elphick authored
    This is a reland of f2e65226
    
    Nothing has changed but
    https://chromium-review.googlesource.com/c/v8/v8/+/1585269 has been rolled
    back due to v8:9234.
    
    Original change's description:
    > Reland "[compiler] Don't collect source positions for the top frame"
    >
    > Fixed crashes by adding missing call to EnsureSourcePositionsAvailable,
    > which requires clearing and restoring the pending exception.
    >
    > > While most source positions were not collected even throwing exceptions,
    > > the top frame still was always collected as it was used to initialize
    > > the JSMessageObject. This skips even that frame, by storing the
    > > SharedFunctionInfo and bytecode offset in the JSMessageObject allowing
    > > it to lazily evaluate the actual source position.
    > >
    > > Also adds tests to test-api.cc that test each of the source position
    > > functions in isolation to ensure that they don't rely on previous
    > > invocations to call the source collection function.
    > >
    > > Since no source positions are now collected at the point when an
    > > exception is thrown, the mjsunit/stack-traces-overflow now passes again
    > > with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the
    > > only failure).
    >
    > Bug: v8:8510
    > Change-Id: Ifa5fe31d3db34a6c6d6a9cef3d646ad620dabd81
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601270
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61372}
    
    TBR=ulan@chromium.org
    
    Bug: v8:8510
    Change-Id: Iaa9e376f90d10c0f25d1bcc352808363e4ea8b4d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1605946Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61418}
    bf9e3e4d
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...