• Clemens Backes's avatar
    [wasm] Fix termination on breakpoint · bbdb8916
    Clemens Backes authored
    If the debug handler (called via {OnDebugBreak}) requests termination of
    the isolate, this would only get considered on the next stack check,
    where it is turned into a proper termination exception.
    
    Handling this correctly is further complicated by the {DebugScope}
    blocking any handling of interrupts via the included
    {PostponeInterruptsScope}.
    
    Hence this CL refactors the code to call any debug handlers in a second
    function which has the {DebugScope}, and to check for interrupts after
    leaving that scope.
    
    R=thibaudm@chromium.org
    CC=bmeurer@chromium.org
    
    Bug: chromium:1319343
    Change-Id: Ia2df0f2610d50eedc6437841c4bf1d2ad3ac9125
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605228Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80235}
    bbdb8916
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...