• Danil Somsikov's avatar
    Revert "Calls to {console} require an access check for the provided arguments" · 52f1d69e
    Danil Somsikov authored
    This reverts commit a5fd60e1.
    
    Reason for revert: As per crbug/1213374 this is not applied consistently. E.g. wrapping object into an array will bypass access checks. With the crrev/c/3041424 however, only accessible properties are shown in console, so logging a restricted object is no longer unsafe.
    
    Original change's description:
    > Calls to {console} require an access check for the provided arguments
    >
    > This CL adds an access check for the arguments to all calls to
    > {console} like {console.log}. This is needed since the DevTools
    > protocol notificiation event does not contain the context in which
    > the {console.log} call occurred. Only the context of the argument.
    > When DevTools then reads properties for the preview of the argument,
    > it uses arguments context, instead of the calling context, potentially
    > leaking objects/exceptions into the calling context.
    >
    > Bug: chromium:987502, chromium:986393
    > Change-Id: I6f7682f7bee94a28ac61994bad259bd003511c39
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741664
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63122}
    
    Bug: chromium:987502, chromium:986393, chromium:1213374
    Change-Id: I92a8bb7663ff97de8831ddeb2c8560fb9fa1c12e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3046189Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Danil Somsikov <dsv@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75881}
    52f1d69e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...