• Leszek Swirski's avatar
    Reland "[offthread] Template deserializer on Isolate" · 6f898234
    Leszek Swirski authored
    This is a reland of e24fa913
    It fixes the heap verification errors by going back to using MakeThin
    instead of manually creating a filler (that then makes the verifier
    think that this was array left-trimming).
    
    Original change's description:
    > [offthread] Template deserializer on Isolate
    >
    > Make the deserializer class templated on Isolate/LocalIsolate. This
    > allows the ObjectSerializer to be split into a main-thread and offthread
    > variant, with the latter taking a LocalIsolate.
    >
    > Eventually, we probably want to anyway split off the code-cache de/serializer
    > to a separate implementation (for various reasons), and this the only one that
    > wants off-thread finalization, and at this point the deserializer can revert
    > back to being un-templated, used only for bootstrapping. However, this is the
    > simplest way, for now, to enable off-thread deserialization.
    >
    > Bug: chromium:1075999
    > Change-Id: I49c0d2c5409f0aa58183673785296756c3714f22
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562254
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75834}
    
    Bug: chromium:1075999
    Change-Id: I1d81fad2550a2a9f04dd0f9d8e66422d28faf378
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3043960Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75918}
    6f898234
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
shared-mutex-guard-if-off-thread.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...