• Peter Marshall's avatar
    [inspector] Throw during debug-eval when accessing function prototypes · 9691c5cf
    Peter Marshall authored
    Function prototypes can be lazily allocated. This means they go into the
    temporary objects set that debug-eval uses to figure out if a write
    will be side-effect free.
    
    We were incorrectly classifying writes to function prototypes as
    side-effect free because the prototype happened to be lazily allocated
    when we first accessed it during debug-eval, but was actually reachable
    from the function (not allocated temporarily).
    
    To do this we introduced a way to temporarily turn off the temporary
    object tracking, and we use it when lazily allocating function
    prototypes.
    
    This could mean that we incorrectly report side-effects when writing to
    function prototypes for functions which were themselves created during
    debug-eval side-effect free mode. However, it's unclear if this is a
    problem, because function declarations set global variables which would
    already throw due to side-effects.
    
    Bug: chromium:1154193
    Change-Id: I444a673662095f6deabaafdce3cdf3d86b71446d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581968Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71692}
    9691c5cf
Name
Last commit
Last update
..
add-binding-expected.txt Loading commit data...
add-binding.js Loading commit data...
await-promise-expected.txt Loading commit data...
await-promise.js Loading commit data...
call-function-on-async-expected.txt Loading commit data...
call-function-on-async.js Loading commit data...
clear-of-command-line-api-expected.txt Loading commit data...
clear-of-command-line-api.js Loading commit data...
client-console-api-message-expected.txt Loading commit data...
client-console-api-message.js Loading commit data...
command-line-api-expected.txt Loading commit data...
command-line-api-without-side-effects-expected.txt Loading commit data...
command-line-api-without-side-effects.js Loading commit data...
command-line-api.js Loading commit data...
compile-script-expected.txt Loading commit data...
compile-script.js Loading commit data...
console-api-repeated-in-console-expected.txt Loading commit data...
console-api-repeated-in-console.js Loading commit data...
console-assert-expected.txt Loading commit data...
console-assert.js Loading commit data...
console-context-expected.txt Loading commit data...
console-context.js Loading commit data...
console-line-and-column-expected.txt Loading commit data...
console-line-and-column.js Loading commit data...
console-log-doesnt-run-microtasks-expected.txt Loading commit data...
console-log-doesnt-run-microtasks.js Loading commit data...
console-memory-expected.txt Loading commit data...
console-memory.js Loading commit data...
console-messages-limits-expected.txt Loading commit data...
console-messages-limits.js Loading commit data...
console-methods-expected.txt Loading commit data...
console-methods.js Loading commit data...
console-spec-expected.txt Loading commit data...
console-spec.js Loading commit data...
console-table-expected.txt Loading commit data...
console-table.js Loading commit data...
console-time-end-format-expected.txt Loading commit data...
console-time-end-format.js Loading commit data...
console-time-log-expected.txt Loading commit data...
console-time-log.js Loading commit data...
console-time-repeat-expected.txt Loading commit data...
console-time-repeat.js Loading commit data...
console-timestamp-expected.txt Loading commit data...
console-timestamp.js Loading commit data...
context-destroyed-on-context-collected-expected.txt Loading commit data...
context-destroyed-on-context-collected.js Loading commit data...
create-context-expected.txt Loading commit data...
create-context.js Loading commit data...
custom-preview-expected.txt Loading commit data...
custom-preview.js Loading commit data...
enable-async-stack-expected.txt Loading commit data...
enable-async-stack.js Loading commit data...
error-preview-expected.txt Loading commit data...
error-preview.js Loading commit data...
es6-module-expected.txt Loading commit data...
es6-module.js Loading commit data...
evaluate-async-expected.txt Loading commit data...
evaluate-async-with-wrap-error-expected.txt Loading commit data...
evaluate-async-with-wrap-error.js Loading commit data...
evaluate-async.js Loading commit data...
evaluate-empty-stack-expected.txt Loading commit data...
evaluate-empty-stack.js Loading commit data...
evaluate-new-function-error-expected.txt Loading commit data...
evaluate-new-function-error.js Loading commit data...
evaluate-repl-await-expected.txt Loading commit data...
evaluate-repl-await.js Loading commit data...
evaluate-repl-mode-code-cache-expected.txt Loading commit data...
evaluate-repl-mode-code-cache.js Loading commit data...
evaluate-repl-mode-expected.txt Loading commit data...
evaluate-repl-mode-side-effecting-expected.txt Loading commit data...
evaluate-repl-mode-side-effecting.js Loading commit data...
evaluate-repl-mode.js Loading commit data...
evaluate-run-microtasks-expected.txt Loading commit data...
evaluate-run-microtasks.js Loading commit data...
evaluate-timeout-expected.txt Loading commit data...
evaluate-timeout.js Loading commit data...
evaluate-unserializable-expected.txt Loading commit data...
evaluate-unserializable.js Loading commit data...
evaluate-with-context-id-equal-zero-expected.txt Loading commit data...
evaluate-with-context-id-equal-zero.js Loading commit data...
evaluate-with-disable-breaks-expected.txt Loading commit data...
evaluate-with-disable-breaks.js Loading commit data...
evaluate-with-generate-preview-expected.txt Loading commit data...
evaluate-with-generate-preview.js Loading commit data...
evaluate-without-side-effects-expected.txt Loading commit data...
evaluate-without-side-effects.js Loading commit data...
exception-thrown-expected.txt Loading commit data...
exception-thrown.js Loading commit data...
exceptionthrown-on-connect-expected.txt Loading commit data...
exceptionthrown-on-connect.js Loading commit data...
function-location-expected.txt Loading commit data...
function-location.js Loading commit data...
function-scopes-expected.txt Loading commit data...
function-scopes.js Loading commit data...
get-heap-usage-expected.txt Loading commit data...
get-heap-usage.js Loading commit data...
get-isolate-id-expected.txt Loading commit data...
get-isolate-id.js Loading commit data...
get-properties-expected.txt Loading commit data...
get-properties-on-proxy-expected.txt Loading commit data...
get-properties-on-proxy.js Loading commit data...
get-properties-preview-expected.txt Loading commit data...
get-properties-preview.js Loading commit data...
get-properties.js Loading commit data...
internal-properties-entries-expected.txt Loading commit data...
internal-properties-entries.js Loading commit data...
internal-properties-expected.txt Loading commit data...
internal-properties.js Loading commit data...
length-or-size-description-expected.txt Loading commit data...
length-or-size-description.js Loading commit data...
property-on-console-proto-expected.txt Loading commit data...
property-on-console-proto.js Loading commit data...
protocol-works-with-different-locale-expected.txt Loading commit data...
protocol-works-with-different-locale.js Loading commit data...
query-objects-expected.txt Loading commit data...
query-objects.js Loading commit data...
regress-1075763-expected.txt Loading commit data...
regress-1075763.js Loading commit data...
regress-1078205-expected.txt Loading commit data...
regress-1078205.js Loading commit data...
regress-986051-expected.txt Loading commit data...
regress-986051.js Loading commit data...
regression-1052721-expected.txt Loading commit data...
regression-1052721.js Loading commit data...
regression-1140845-expected.txt Loading commit data...
regression-1140845.js Loading commit data...
regression-732717-expected.txt Loading commit data...
regression-732717.js Loading commit data...
regression-736302-expected.txt Loading commit data...
regression-736302.js Loading commit data...
release-object-expected.txt Loading commit data...
release-object.js Loading commit data...
remote-object-expected.txt Loading commit data...
remote-object-get-properties-expected.txt Loading commit data...
remote-object-get-properties.js Loading commit data...
remote-object.js Loading commit data...
run-script-async-expected.txt Loading commit data...
run-script-async.js Loading commit data...
runtime-disable-preserve-injected-script-expected.txt Loading commit data...
runtime-disable-preserve-injected-script.js Loading commit data...
runtime-evaluate-null-property-expected.txt Loading commit data...
runtime-evaluate-null-property.js Loading commit data...
runtime-evaluate-with-dirty-context-expected.txt Loading commit data...
runtime-evaluate-with-dirty-context.js Loading commit data...
runtime-get-properties-and-accessor-expected.txt Loading commit data...
runtime-get-properties-and-accessor.js Loading commit data...
runtime-global-lexical-scope-names-expected.txt Loading commit data...
runtime-global-lexical-scope-names.js Loading commit data...
runtime-restore-expected.txt Loading commit data...
runtime-restore.js Loading commit data...
set-max-call-stack-size-expected.txt Loading commit data...
set-max-call-stack-size.js Loading commit data...
set-or-map-entries-expected.txt Loading commit data...
set-or-map-entries.js Loading commit data...
terminate-execution-expected.txt Loading commit data...
terminate-execution.js Loading commit data...