• hablich's avatar
    Reland of [compiler] Make feedback vector cope with flag changes. (patchset #1... · b88d048a
    hablich authored
    Reland of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1876103002/ )
    
    Reason for revert:
    Did not fail on another roll including this CL ..
    
    Original issue's description:
    > Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ )
    >
    > Reason for revert:
    > Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001
    >
    > Original issue's description:
    > > [compiler] Make feedback vector cope with flag changes.
    > >
    > > This fixes corner cases where the layout of feedback vectors baked into
    > > the snapshot is different from the expected layout, depending on some
    > > runtime flags. We make sure the feedback vector is regenereated for
    > > functions that are not compiled. Flag changes of this kind are only
    > > allowed when code is not serialized.
    > >
    > > An alternative solution would be to not serialize the feedback vector
    > > for such cases in the first place. That solution however would have a
    > > higher overhead, as it would required the serializer to be able to
    > > recognize feedback vectors while generating a snapshot.
    > >
    > > R=mvstanton@chromium.org
    > > TEST=mjsunit/regress/regress-crbug-600995
    > > BUG=chromium:600995
    > > LOG=n
    > >
    > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c
    > > Cr-Commit-Position: refs/heads/master@{#35339}
    >
    > TBR=mvstanton@chromium.org,mstarzinger@chromium.org
    >
    > BUG=chromium:600995
    > LOG=N
    > NOTRY=true
    >
    > Committed: https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa
    > Cr-Commit-Position: refs/heads/master@{#35392}
    
    TBR=mvstanton@chromium.org,mstarzinger@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:600995
    
    Review URL: https://codereview.chromium.org/1876973002
    
    Cr-Commit-Position: refs/heads/master@{#35398}
    b88d048a
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...