• leszeks's avatar
    [turbofan] Do not replace actual duplicates when value numbering · b7761100
    leszeks authored
    The value numbering reducer has collision checks for nodes that mutated,
    but kept the same hash, and are now equivalent to another node. However,
    it can also accidentally hit itself, if it mutated, changed hash, but
    ran over the location it was previously in.
    
    After this patch, it checks to see if it is comparing against itself,
    and skips over itself. Additionally, if this check is at the end of the
    collisions, it opportunistically removes the duplicate entry and reduces
    the size pressure on the list. We can do the same opportunistic clean up
    if we happen to find a colliding equivalent entry, since we move it from
    its original position to a new one.
    
    Drive-by change: Ensure that the collision replacement checks types in
    the same way that normal replacement does.
    
    Review-Url: https://codereview.chromium.org/2475653002
    Cr-Commit-Position: refs/heads/master@{#40757}
    b7761100
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...