• Leszek Swirski's avatar
    Revert "fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references" · e9ff38bb
    Leszek Swirski authored
    This reverts commit 13a04aba.
    
    Reason for revert: Breaks v8 roll (https://chromium-review.googlesource.com/c/chromium/src/+/1698024)
    
    Original change's description:
    > fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references
    > 
    > This change fixes missing symbol errors in the Windows 10 on ARM build
    > of Node.js.
    > 
    > When a whole class is marked for export, all of its members are marked
    > as well. This can be a problem when inline members call undefined yet
    > inline members of other classes: the exported function will contain a
    > reference to the undefined inline function that should be satisfied at
    > link time, but because the other function is inline no symbol will be
    > produced that will satisfy that reference.
    > 
    > Clang gets around this by masking inlined class members from export
    > using /Fc:dllexportInlines-. This is why b0a2a567 worked.
    > 
    > Node.js' Windows builds use MSVC and so do not have access to this
    > flag. This results in unresolved symbols at link time.
    > 
    > Bug: v8:9465
    > Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62660}
    
    TBR=sigurds@chromium.org,jgruber@chromium.org,ishell@chromium.org,jkunkee@microsoft.com
    
    Change-Id: Ief2ccb35fc19b00975e78a63791a558525d49ee9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9465
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1700069Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62694}
    e9ff38bb
Name
Last commit
Last update
..
assembler-arm64-inl.h Loading commit data...
assembler-arm64.cc Loading commit data...
assembler-arm64.h Loading commit data...
constants-arm64.h Loading commit data...
cpu-arm64.cc Loading commit data...
decoder-arm64-inl.h Loading commit data...
decoder-arm64.cc Loading commit data...
decoder-arm64.h Loading commit data...
instructions-arm64-constants.cc Loading commit data...
instructions-arm64.cc Loading commit data...
instructions-arm64.h Loading commit data...
instrument-arm64.cc Loading commit data...
instrument-arm64.h Loading commit data...
interface-descriptors-arm64.cc Loading commit data...
macro-assembler-arm64-inl.h Loading commit data...
macro-assembler-arm64.cc Loading commit data...
macro-assembler-arm64.h Loading commit data...
register-arm64.cc Loading commit data...
register-arm64.h Loading commit data...
utils-arm64.cc Loading commit data...
utils-arm64.h Loading commit data...