• Clemens Hammacher's avatar
    [wasm] Deprecate reachability tracking in SsaEnv · b534e00e
    Clemens Hammacher authored
    Reachability is already being tracked in the function body decoder.
    This CL adds a DCHECK that the reachability tracked in the SsaEnv
    matches the reachability tracked in the function body decoder. Most of
    our methods will only be called for reachable code anyway.
    For exceptions, we still track reachability explicitly for now in the
    wasm graph builder, this can be refactored in the future by improving
    reachability tracking for catch blocks in the function body decoder.
    
    If this DCHECK survives fuzzing for a few days, we can remove code that
    handles unreachable code in graph-building-interface.cc.
    
    R=herhut@chromium.org
    
    Bug: v8:8423, v8:8611
    Change-Id: I0fb375c99497352aad396816566883fe234ca0ac
    Reviewed-on: https://chromium-review.googlesource.com/c/1384089Reviewed-by: 's avatarStephan Herhut <herhut@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58368}
    b534e00e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...