• Leszek Swirski's avatar
    Revert "[wasm] Ensure that only TurboFan code is serialized" · cf325b5a
    Leszek Swirski authored
    This reverts commit 60ee70bb.
    
    Reason for revert: wasm-api-tests/WasmCapiTest.Serialize starts flaking: https://crbug.com/v8/10784
    
    Original change's description:
    > [wasm] Ensure that only TurboFan code is serialized
    > 
    > We have the implicit assumption that Liftoff code will never be
    > serialized, and we start relying on that when implementing new features
    > (debugging, dynamic tiering).
    > 
    > This CL makes the serializer fail if the module contains any Liftoff
    > code. Existing tests are changed to ensure that we fully tiered up
    > before serializing a module (similar to the logic in Chromium).
    > The "wasm-clone-module" test needs to serialize the module before
    > enabling the debugger.
    > 
    > Note that chrome currently only serializes a module after it fully
    > tiered up, so that should be fine. If other embedders need the ability
    > to serialize a module in an arbitrary state, we will have to fix this
    > later. With this CL we will be on the safe side though and (gracefully)
    > fail serialization instead of accidentally serializing Liftoff code.
    > 
    > R=​ahaas@chromium.org
    > 
    > Bug: v8:10777
    > Change-Id: I1245e5f7fda3447a544c1e3525e1239cde759174
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336799
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69276}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: Ic1349375bd562bb0a2724c39c27ef3247461c97b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10777
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2342845Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69284}
    cf325b5a
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...