• Benedikt Meurer's avatar
    [debug] Set breakpoints correctly right after function literals. · 6d25f20f
    Benedikt Meurer authored
    The logic to locate the correct function to set a breakpoint in based
    on script position was treating SharedFunctionInfo::EndPosition() as
    inclusive rather than exclusive. There are various assumptions all over
    the Debugger that seem to demand this treatment for the toplevel script.
    But it's definitely wrong for function literals.
    
    Fixed: chromium:1253277
    Change-Id: I3421703673f4d78aee28e923e03e2fca24bc06ac
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197715
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77186}
    6d25f20f
Name
Last commit
Last update
..
console Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...