• Benedikt Meurer's avatar
    [debug] Set breakpoints correctly right after function literals. · 6d25f20f
    Benedikt Meurer authored
    The logic to locate the correct function to set a breakpoint in based
    on script position was treating SharedFunctionInfo::EndPosition() as
    inclusive rather than exclusive. There are various assumptions all over
    the Debugger that seem to demand this treatment for the toplevel script.
    But it's definitely wrong for function literals.
    
    Fixed: chromium:1253277
    Change-Id: I3421703673f4d78aee28e923e03e2fca24bc06ac
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197715
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77186}
    6d25f20f
Name
Last commit
Last update
..
wasm/gdb-server Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.cc Loading commit data...
debug-interface.h Loading commit data...
debug-property-iterator.cc Loading commit data...
debug-property-iterator.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug-wasm-objects-inl.h Loading commit data...
debug-wasm-objects.cc Loading commit data...
debug-wasm-objects.h Loading commit data...
debug-wasm-objects.tq Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
interface-types.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...