• Georg Neis's avatar
    No longer desugar the exponentiation (**) operator. · b97567a9
    Georg Neis authored
    Prior to this change, the exponentiation operator was rewritten by the
    parser to a call of the Math.pow builtin. However, Math.pow does not
    accept BigInt arguments, while the exponentiation operator must accept
    them.
    
    This CL
    - removes the parser's special treatment of ** and **=, treating them
      like any other binary op instead.
    - adds a TFC builtin Exponentiate that does the right thing for
      all inputs.
    - adds interpreter bytecodes Exp and ExpSmi whose handlers call the
      Exponentiate builtin. For simplicity, they currently always collect
      kAny feedback.
    - adds a Turbofan operator JSExponentiate with a typed-lowering to
      the existing NumberPow and a generic-lowering to the Exponentiate
      builtin. There is currently no speculative lowering.
    
    Note that exponentiation for BigInts is actually not implemented yet,
    so we can't yet test it.
    
    Bug: v8:6791
    Change-Id: Id90914c9c3fce310ce01e715c09eaa9f294f4f8a
    Reviewed-on: https://chromium-review.googlesource.com/785694Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49696}
    b97567a9
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
parser Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.gyp Loading commit data...
unittests.isolate Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...