• Clemens Backes's avatar
    Reland "[wasm] Move write scope out of NativeModule::AddCode" · dd152c48
    Clemens Backes authored
    This is a reland of 6ae18c2d, with
    {CompileWasmCapiCallWrapper} fixed to also contain a
    {CodeSpaceWriteScope}.
    
    Original change's description:
    > [wasm] Move write scope out of NativeModule::AddCode
    >
    > {NativeModule::AddCode} is a central method that should usually be
    > called in batches, where the caller holds a {CodeSpaceWriteScope} for a
    > longer time (over several compilations).
    > This CL moves us closer to that by removing the scope from that central
    > method and instead putting it in callers where it becomes more visible.
    > There are already TODOs to introduce caching or batching to avoid some
    > switching, and one more TODO is added.
    >
    > Drive-by: Remove an unneeded {CodeSpaceMemoryModificationScope}.
    >
    > R=jkummerow@chromium.org
    >
    > Bug: v8:11974
    > Change-Id: Ia13c601abc766e5fca6ca053bf1fc4d647b53ed0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098186
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76344}
    
    Bug: v8:11974
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Change-Id: I6367bbd9dc52c403513eb1a168aa1f6eb4044ca1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3129703Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76626}
    dd152c48
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...