• clemensh's avatar
    [wasm] Fix ToNumber conversion · ae1c5746
    clemensh authored
    There were two bugs, one partly hiding the other one:
    1) We generate the ToNumber conversion for each WASM_TO_JS wrapper,
       even if the expected return type is void.
    2) The return node in the WASM_TO_JS wrapper did not use the effect of
       the ToNumber conversion.
    
    This CL fixes both, and adds test cases to check that we do throw an
    error trying to convert (e.g.) Symbol to a number, but only if the
    return type is not void.
    Additional test check that a user-provided valueOf method is actually
    called the correct number of times.
    
    R=titzer@chromium.org, bradnelson@chromium.org
    BUG=v8:4203
    
    Review-Url: https://codereview.chromium.org/2552123004
    Cr-Commit-Position: refs/heads/master@{#41552}
    ae1c5746
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...