• Andreas Haas's avatar
    [wasm] Allow WebAssembly.Global.value.set to be called with undefined · ad938456
    Andreas Haas authored
    A spec test (wasm-js/global/value-get-set) requires
    WebAssembly.Global.value.set to throw an exception if it is called with
    0 arguments. The implementation in V8, however, just checked if the
    first parameter is `undefined`. This implementation indeed threw an
    exception if 0 arguments were provided, but it also threw an exception
    when `undefined` is provided as a parameter. This, however, violates
    the spec, because globals can be reset to `undefined`.
    
    With this CL we replace the checking for `undefined` by checking the
    length of the arguments that get provided.
    
    R=ecmziegler@chromium.org
    
    Bug: chromium:1211342
    Change-Id: Ic87a0b369dea3e49eddb8f71f2c29dc6a8f5f558
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940901Reviewed-by: 's avatarEmanuel Ziegler <ecmziegler@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74982}
    ad938456
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...