• pthier's avatar
    Reland "[sparkplug] Change bytecode offset mapping and introduce iterator." · 2966c896
    pthier authored
    This is a reland of a8b61ef5
    
    The main reason for the revert was not related to this CL and was fixed
    with https://crrev.com/c/2739646
    In addition debug output in d8.test.verifySourcePositions was removed
    due to TSAN complaints.
    
    Original change's description:
    > [sparkplug] Change bytecode offset mapping and introduce iterator.
    >
    > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to
    > create a mapping of bytecode offset <-> sparkplug pc.
    > These pairs were only recorded after builtin/runtime calls.
    > In preparation for deoptimizing to Sparkplug, we need a more precise
    > mapping.
    > With this CL, we record positions for every bytecode. Instead of storing
    > a pair of (bytecode offset, sparkplug pc), we store only the pc,
    > calculating the bytecode offset from the index in the mapping table.
    > For easier use an iterator to access the mapping is introduced.
    >
    > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of
    flaky failures.
    >
    > Bug: v8:11420, v8:11429
    > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Auto-Submit: Patrick Thier <pthier@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73186}
    >
    > Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    
    Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745335Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73293}
    2966c896
Name
Last commit
Last update
..
OWNERS Loading commit data...
async-hooks-wrapper.cc Loading commit data...
async-hooks-wrapper.h Loading commit data...
cov.cc Loading commit data...
cov.h Loading commit data...
d8-console.cc Loading commit data...
d8-console.h Loading commit data...
d8-js.cc Loading commit data...
d8-platforms.cc Loading commit data...
d8-platforms.h Loading commit data...
d8-posix.cc Loading commit data...
d8-windows.cc Loading commit data...
d8.cc Loading commit data...
d8.h Loading commit data...