• Sathya Gunasekaran's avatar
    Revert "Reland "[compiler] Consider IsPendingAllocation in Ref construction"" · abfdbaf2
    Sathya Gunasekaran authored
    This reverts commit 4683d6fe.
    
    Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/36744/overview
    
    
    Original change's description:
    > Reland "[compiler] Consider IsPendingAllocation in Ref construction"
    >
    > This is a reland of 5f0ac36c
    >
    > Fixes Ref construction failures in:
    > - MapRef::instance_descriptors
    > - NativeContext reads (see also crrev.com/c/2891575)
    >
    > Original change's description:
    > > [compiler] Consider IsPendingAllocation in Ref construction
    > >
    > > The logic in JSHeapBroker::TryGetOrCreateData assumes that parts
    > > of the object are safe to read. In particular, the instance type
    > > must be readable for the chain of `Is##Name()` type checks.
    > >
    > > This is guaranteed if
    > >
    > >  - a global memory fence happened after object initialization and
    > >    prior to the read by the compiler; or
    > >  - the object was published through a release store and read through
    > >    an acquire read.
    > >
    > > The former is protected by the new call to ObjectMayBeUninitialized
    > > (which internally calls IsPendingAllocation) in TryGetOrCreateData.
    > >
    > > The latter must be marked explicitly by calling the new
    > > MakeRefAssumeMemoryFence variant.
    > >
    > > Note that support in this CL is expected to be incomplete and will
    > > have to be extended in the future as more cases show up in which
    > > MakeRef calls must be converted to MakeRefAssumeMemoryFence or to
    > > TryMakeRef.
    > >
    > > Bug: v8:7790,v8:11711
    > > Change-Id: Ic2f7d9fc46e4bfc3f6bbe42816f73fc5ec174337
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874663
    > > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#74474}
    >
    > Bug: v8:7790,v8:11711,chromium:1207680,chromium:1207679
    > Change-Id: Ib3dbf59909e6982a3230dd6a67c9fb7d6ffb9ab4
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2886861
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74587}
    
    Bug: v8:7790
    Bug: v8:11711
    Bug: chromium:1207680
    Bug: chromium:1207679
    Change-Id: I8cd45ac006b7b5f3d668d0df272bcba880c75926
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2901990Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74621}
    abfdbaf2
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...