• Benedikt Meurer's avatar
    Reland "[inspector] Consistently format all native accessors as own properties." · fb86158a
    Benedikt Meurer authored
    This is a reland of ce8cef36
    
    Original change's description:
    > [inspector] Consistently format all native accessors as own properties.
    >
    > Previously the V8 inspector would only turn embedder accessors on the
    > prototype chain into data properties, but would not do the same for
    > ECMAScript builtins, which is kind of inconsistent and weird behavior.
    >
    > This leaves in the hack that the inspector reports native accessor
    > properties as (own) data properties, but now at least the very least
    > does so consistently. In the absence of a better solution, we'll go
    > with this for now.
    >
    > Bug: chromium:1076820, chromium:1199247
    > Change-Id: I593f909a46cb714dbec629a2944eeb892881ba6f
    > Before: https://imgur.com/kPuSldj.png
    > After: https://imgur.com/eFau45m.png
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067319
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#76059}
    
    Bug: chromium:1076820, chromium:1199247
    Change-Id: I11987194b0d0b8b250eda4f8ce0ae5fc743eb27c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3070701
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76084}
    fb86158a
Name
Last commit
Last update
..
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
custom-preview.cc Loading commit data...
custom-preview.h Loading commit data...
injected-script.cc Loading commit data...
injected-script.h Loading commit data...
inspected-context.cc Loading commit data...
inspected-context.h Loading commit data...
inspector_protocol_config.json Loading commit data...
remote-object-id.cc Loading commit data...
remote-object-id.h Loading commit data...
search-util.cc Loading commit data...
search-util.h Loading commit data...
string-16.cc Loading commit data...
string-16.h Loading commit data...
string-util.cc Loading commit data...
string-util.h Loading commit data...
test-interface.cc Loading commit data...
test-interface.h Loading commit data...
v8-console-agent-impl.cc Loading commit data...
v8-console-agent-impl.h Loading commit data...
v8-console-message.cc Loading commit data...
v8-console-message.h Loading commit data...
v8-console.cc Loading commit data...
v8-console.h Loading commit data...
v8-debugger-agent-impl.cc Loading commit data...
v8-debugger-agent-impl.h Loading commit data...
v8-debugger-id.cc Loading commit data...
v8-debugger-id.h Loading commit data...
v8-debugger-script.cc Loading commit data...
v8-debugger-script.h Loading commit data...
v8-debugger.cc Loading commit data...
v8-debugger.h Loading commit data...
v8-heap-profiler-agent-impl.cc Loading commit data...
v8-heap-profiler-agent-impl.h Loading commit data...
v8-inspector-impl.cc Loading commit data...
v8-inspector-impl.h Loading commit data...
v8-inspector-session-impl.cc Loading commit data...
v8-inspector-session-impl.h Loading commit data...
v8-profiler-agent-impl.cc Loading commit data...
v8-profiler-agent-impl.h Loading commit data...
v8-regex.cc Loading commit data...
v8-regex.h Loading commit data...
v8-runtime-agent-impl.cc Loading commit data...
v8-runtime-agent-impl.h Loading commit data...
v8-schema-agent-impl.cc Loading commit data...
v8-schema-agent-impl.h Loading commit data...
v8-stack-trace-impl.cc Loading commit data...
v8-stack-trace-impl.h Loading commit data...
v8-string-conversions.cc Loading commit data...
v8-string-conversions.h Loading commit data...
v8-value-utils.cc Loading commit data...
v8-value-utils.h Loading commit data...
value-mirror.cc Loading commit data...
value-mirror.h Loading commit data...