• Clemens Backes's avatar
    [wasm] Improve code size estimates · aadf812c
    Clemens Backes authored
    UMA data shows that we currently still allocate up to ten code spaces
    per module. This is because the code size estimates are vastly off,
    especially if both Liftoff and TurboFan is being used.
    Also, code sizes differ by platform.
    
    This CL adds more logic to the {EstimateNativeModuleCodeSize} function
    to distinguish Liftoff and TurboFan, and to use different constants per
    platform. A largeish comment explains how the numbers were generated,
    and that they are an extreme over-generalization. However, without
    further information about the module, this is the best we can do.
    After all, being off even by a factor of two does not hurt too much, as
    explained in the comment.
    
    R=jkummerow@chromium.org
    
    Change-Id: Icd178f5f4d0c7c8fa29b11b6eff7d14e64a1af1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910102
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64913}
    aadf812c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...