• Leszek Swirski's avatar
    [isolate] Make field getters use a const Isolate* · 42a56e03
    Leszek Swirski authored
    To indicate that the Isolate* in getters might not be a "real" isolate,
    but rather a calculated one from GetIsolateForPtrCompr only used for
    calculating the isolate root, make that function return a const Isolate*
    and change field getters, Object::IsFoo predicates, and related
    functions to all take a const Isolate* instead of an Isolate*
    
    With this change, we can slightly more confidently use Objects that are
    in OffThreadSpace, without having to worry too much about having an
    Isolate* floating around that could accidentally be used.
    
    This is a slight abuse of const semantics, but it allows implicit
    conversion from Isolate* arguments to the const Isolate* parameter.
    
    Bug: v8:7703
    Bug: chromium:1011762
    Change-Id: I54d4a65d2299477195f4d754cabe64ce34fdaa4c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939455
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65199}
    42a56e03
Name
Last commit
Last update
..
ls Loading commit data...
OWNERS Loading commit data...
ast.h Loading commit data...
cfg.cc Loading commit data...
cfg.h Loading commit data...
class-debug-reader-generator.cc Loading commit data...
constants.h Loading commit data...
contextual.h Loading commit data...
csa-generator.cc Loading commit data...
csa-generator.h Loading commit data...
declarable.cc Loading commit data...
declarable.h Loading commit data...
declaration-visitor.cc Loading commit data...
declaration-visitor.h Loading commit data...
declarations.cc Loading commit data...
declarations.h Loading commit data...
earley-parser.cc Loading commit data...
earley-parser.h Loading commit data...
global-context.cc Loading commit data...
global-context.h Loading commit data...
implementation-visitor.cc Loading commit data...
implementation-visitor.h Loading commit data...
instance-type-generator.cc Loading commit data...
instructions.cc Loading commit data...
instructions.h Loading commit data...
parameter-difference.h Loading commit data...
server-data.cc Loading commit data...
server-data.h Loading commit data...
source-positions.cc Loading commit data...
source-positions.h Loading commit data...
torque-compiler.cc Loading commit data...
torque-compiler.h Loading commit data...
torque-parser.cc Loading commit data...
torque-parser.h Loading commit data...
torque.cc Loading commit data...
type-inference.cc Loading commit data...
type-inference.h Loading commit data...
type-oracle.cc Loading commit data...
type-oracle.h Loading commit data...
type-visitor.cc Loading commit data...
type-visitor.h Loading commit data...
types.cc Loading commit data...
types.h Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...