• Leszek Swirski's avatar
    [isolate] Make field getters use a const Isolate* · 42a56e03
    Leszek Swirski authored
    To indicate that the Isolate* in getters might not be a "real" isolate,
    but rather a calculated one from GetIsolateForPtrCompr only used for
    calculating the isolate root, make that function return a const Isolate*
    and change field getters, Object::IsFoo predicates, and related
    functions to all take a const Isolate* instead of an Isolate*
    
    With this change, we can slightly more confidently use Objects that are
    in OffThreadSpace, without having to worry too much about having an
    Isolate* floating around that could accidentally be used.
    
    This is a slight abuse of const semantics, but it allows implicit
    conversion from Isolate* arguments to the const Isolate* parameter.
    
    Bug: v8:7703
    Bug: chromium:1011762
    Change-Id: I54d4a65d2299477195f4d754cabe64ce34fdaa4c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939455
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65199}
    42a56e03
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...