• Jakob Gruber's avatar
    Reland "[regexp] Limit the size of inlined choice nodes" · 10842cad
    Jakob Gruber authored
    This is a reland of 6a0e7224
    
    Original change's description:
    > [regexp] Limit the size of inlined choice nodes
    >
    > Codegen for unicode property escapes (e.g.: /\p{L}/u) can produce huge
    > code objects. This effect can be further magnified through inlining,
    > leading to exponential code growth in the size of the pattern.
    >
    > This CL is a (fairly hacky) way to avoid exponential growth. We
    > recognize choice nodes with 'many' choices and disable inlining for
    > them. In the future we should fix this properly, either by using the
    > code size budget correctly, or by improving codegen for property
    > escapes.
    >
    > Bug: v8:10441
    > Change-Id: I817f145251ec8b1b9906cc735c9e9bdb004c98ed
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170229
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67433}
    
    Tbr: yangguo@chromium.org
    Bug: v8:10441
    Change-Id: I9a16cc9e8248cb46d3d16a4e2d250968cc1b7b39
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172679Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67462}
    10842cad
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
gen-regexp-special-case.cc Loading commit data...
property-sequences.cc Loading commit data...
property-sequences.h Loading commit data...
regexp-ast.cc Loading commit data...
regexp-ast.h Loading commit data...
regexp-bytecode-generator-inl.h Loading commit data...
regexp-bytecode-generator.cc Loading commit data...
regexp-bytecode-generator.h Loading commit data...
regexp-bytecode-peephole.cc Loading commit data...
regexp-bytecode-peephole.h Loading commit data...
regexp-bytecodes.cc Loading commit data...
regexp-bytecodes.h Loading commit data...
regexp-compiler-tonode.cc Loading commit data...
regexp-compiler.cc Loading commit data...
regexp-compiler.h Loading commit data...
regexp-dotprinter.cc Loading commit data...
regexp-dotprinter.h Loading commit data...
regexp-error.cc Loading commit data...
regexp-error.h Loading commit data...
regexp-interpreter.cc Loading commit data...
regexp-interpreter.h Loading commit data...
regexp-macro-assembler-arch.h Loading commit data...
regexp-macro-assembler-tracer.cc Loading commit data...
regexp-macro-assembler-tracer.h Loading commit data...
regexp-macro-assembler.cc Loading commit data...
regexp-macro-assembler.h Loading commit data...
regexp-nodes.h Loading commit data...
regexp-parser.cc Loading commit data...
regexp-parser.h Loading commit data...
regexp-stack.cc Loading commit data...
regexp-stack.h Loading commit data...
regexp-utils.cc Loading commit data...
regexp-utils.h Loading commit data...
regexp.cc Loading commit data...
regexp.h Loading commit data...
special-case.h Loading commit data...