• Samuel Groß's avatar
    [sandbox] Fix serialization of NativeContext · a9990e08
    Samuel Groß authored
    When a NativeContext is being serialized, the NativeContext's
    microtask_queue is set to nullptr as it is not included in the snapshot.
    However, when the sandbox is enabled, this will only set the pointer in
    the external pointer table to nullptr, but not the handle stored in the
    object. This then causes the deserialized object to briefly be invalid,
    before it's microtask queue handle is (re-)initialized. If a GC runs
    during that timeframe, it will see an invalid external pointer handle,
    which may cause DCHECK failures.
    To fix this, this CL now introduces a generic mechanism for clearing and
    restoring external pointer slots for serialization.
    
    Bug: v8:13218
    Change-Id: I03c8779bbec0a42a0b66687e76c951b1887e6122
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850294Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82677}
    a9990e08
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...