• vabr's avatar
    Report unexpected lexical decl also without destructuring · 454816f0
    vabr authored
    https://codereview.chromium.org/2694003002/ introduced
    "SyntaxError: Lexical declaration cannot appear in a single-statement context"
    for the case when let + desctructuring from a list happen.
    
    As was pointed out in https://codereview.chromium.org/2694003002/#msg18, the
    case without destructuring would also benefit from a better message: if a
    single statement is expected and "let identifier = ..." is seen, the error is
    indeed again that the lexical declaration is not a statement. However, the current
    error is "Unexpected identifier", because the parser tries to accept "let" as
    an identifier in an expression statement, and then gives up seeing the other
    identifier after "let".
    
    This CL ensures that the parser recognises the error properly and reports
    accordingly. It also renames the existing test, which contains destructuring,
    and adds the one with a non-destructuring lexical declaration.
    
    BUG=v8:5686
    
    Review-Url: https://codereview.chromium.org/2697193007
    Cr-Commit-Position: refs/heads/master@{#43275}
    454816f0
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...