• Adam Klein's avatar
    Revert "Remove all custom CopyCharsUnsigned implementations" · 0aac347e
    Adam Klein authored
    This reverts commit 5d8c4890.
    
    Reason for revert: Fails on UBSan bot:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/7946
    
    Original change's description:
    > Remove all custom CopyCharsUnsigned implementations
    > 
    > It's unclear whether the custom implementation have any advantage over
    > the standard library one's.
    > Since we update our toolchain and standard library regularly, it might
    > well be the case that the custom implementations are slower by now.
    > 
    > Thus this CL removes all {CopyCharsUnsigned} implementations and
    > implements {CopyChars} generically using {std::copy_n}.
    > 
    > Note that this does not touch the {MemMove} and {MemCopy} functions
    > yet, as we have seen regressions when trying to remove them before
    > (https://crbug.com/v8/8675#c5).
    > 
    > R=​leszeks@chromium.org
    > 
    > Bug: v8:9396
    > Change-Id: I97a183afebcccd2fbb567bdba02e827331475608
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800577
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63808}
    
    TBR=leszeks@chromium.org,clemensh@chromium.org
    
    Change-Id: Ia16da942c7c28ba71076d1e3b0b8a6388a4ba359
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9396
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806103Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63810}
    0aac347e
Name
Last commit
Last update
..
OWNERS Loading commit data...
expression-scope-reparenter.cc Loading commit data...
expression-scope-reparenter.h Loading commit data...
expression-scope.h Loading commit data...
func-name-inferrer.cc Loading commit data...
func-name-inferrer.h Loading commit data...
keywords-gen.h Loading commit data...
keywords.txt Loading commit data...
literal-buffer.cc Loading commit data...
literal-buffer.h Loading commit data...
parse-info.cc Loading commit data...
parse-info.h Loading commit data...
parser-base.h Loading commit data...
parser.cc Loading commit data...
parser.h Loading commit data...
parsing.cc Loading commit data...
parsing.h Loading commit data...
pending-compilation-error-handler.cc Loading commit data...
pending-compilation-error-handler.h Loading commit data...
preparse-data-impl.h Loading commit data...
preparse-data.cc Loading commit data...
preparse-data.h Loading commit data...
preparser-logger.h Loading commit data...
preparser.cc Loading commit data...
preparser.h Loading commit data...
rewriter.cc Loading commit data...
rewriter.h Loading commit data...
scanner-character-streams.cc Loading commit data...
scanner-character-streams.h Loading commit data...
scanner-inl.h Loading commit data...
scanner.cc Loading commit data...
scanner.h Loading commit data...
token.cc Loading commit data...
token.h Loading commit data...