• Clemens Hammacher's avatar
    Speed up compilation and execution of CSA_ASSERTs · a7335920
    Clemens Hammacher authored
    Currently, each single CSA_ASSERT invokation creates its own lambda,
    which is then wrapped in a {std::function} and passed to
    {CodeStubAssembler::Assert}. It takes a lot of compile time for clang
    to generate all the code for that.
    This CL introduces a more light-weight alternative to
    {CodeStubAssembler::Assert} which just receives the node directly.
    This reduces compile time of {code-stub-assembler.cc} in optdebug mode
    from ~30 seconds to ~17 seconds locally.
    
    R=tebbi@chromium.org
    
    Bug: v8:7629
    Change-Id: I4520a7b587cb96319d75048cf11c1124be583d6a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724370Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62976}
    a7335920
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...