• Joyee Cheung's avatar
    [class] parse private accessors · a6dd7f1c
    Joyee Cheung authored
    This patch adds:
    
    - VariableMode::kPrivateMethod
    - VariableMode::kPrivateSetterOnly
    - VariableMode::kPrivateGetterOnly
    - VariableMode::kPrivateGetterAndSetter
    
    And replace the previous RequiresBrandCheckFlag by inferring
    whether the brand check is required from these VariableModes.
    It is then possible to check duplicate non-complementary
    accessors in the parsers and throw early errors, and allow
    complementary accessors to be associated with the same
    private name variable.
    
    This patch also adds the following AssignType:
    
    - PRIVATE_METHOD
    - PRIVATE_GETTER_ONLY
    - PRIVATE_SETTER_ONLY
    - PRIVATE_GETTER_AND_SETTER
    
    corresponding to the new VariableModes so that it's possible
    to generate specialized code for different type of
    private accessor declarations.
    
    Design doc: https://docs.google.com/document/d/10W4begYfs7lmldSqBoQBBt_BKamgT8igqxF9u50RGrI/edit
    
    Bug: v8:8330
    Change-Id: I0fb61b1be248630d1eadd74fb16d7d64a421f4c4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695204
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62988}
    a6dd7f1c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...