• Simon Zünd's avatar
    Calls to {console} require an access check for the provided arguments · a5fd60e1
    Simon Zünd authored
    This CL adds an access check for the arguments to all calls to
    {console} like {console.log}. This is needed since the DevTools
    protocol notificiation event does not contain the context in which
    the {console.log} call occurred. Only the context of the argument.
    When DevTools then reads properties for the preview of the argument,
    it uses arguments context, instead of the calling context, potentially
    leaking objects/exceptions into the calling context.
    
    Bug: chromium:987502, chromium:986393
    Change-Id: I6f7682f7bee94a28ac61994bad259bd003511c39
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741664
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63122}
    a5fd60e1
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...