• Francis McCabe's avatar
    Revert "Reland^3 "[flags] warn about contradictory flags"" · a5756085
    Francis McCabe authored
    This reverts commit dc18b822.
    
    Reason for revert: still causing failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31566
    
    Original change's description:
    > Reland^3 "[flags] warn about contradictory flags"
    > 
    > This is a reland of 0ba115e6
    > Changes:
    > - Also allow second parameter influenced by --cache to be reassigned.
    > - Fix --stress-opt to only --always-opt in the last iteration as before.
    > 
    > Original change's description:
    > > Reland^2 "[flags] warn about contradictory flags"
    > >
    > > This is a reland of d8f8a7e2
    > > Change compared to last reland:
    > > - Do not check for d8 flag contradictions in the presence of --fuzzing
    > > - Allow identical re-declaration of --cache=*
    > >
    > > Original change's description:
    > > > Reland "[flags] warn about contradictory flags"
    > > >
    > > > This is a reland of b8f91666
    > > > Difference to previous CL: Additional functionality to specify
    > > > incompatible flags based on GN variables and extra-flags, used
    > > > to fix the issues that came up on the waterfall.
    > > >
    > > > This also changes the rules regarding repeated flags: While
    > > > explicitly repeated flags are allowed for boolean values as long
    > > > as they are identical, repeated flags or explicit flags in the
    > > > presence of an active implication are disallowed for non-boolean
    > > > flags. The latter simplifies specifying conflict rules in
    > > > variants.py. Otherwise a rule like
    > > >
    > > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
    > > >   "--gc-interval=*": ["--gc-interval=*"],
    > > > }
    > > >
    > > > wouldn't work because specifying the same GC interval twice
    > > > wouldn't actually count as a conflict. This was an issue with
    > > > test/mjsunit/wasm/gc-buffer.js, which specifies
    > > > --gc-interval=500 exactly like the extra flag by the stress bot.
    > > >
    > > > Also, this now expands contradictory flags checking to d8 flags
    > > > for consistency.
    > > >
    > > > Original change's description:
    > > > > [flags] warn about contradictory flags
    > > > >
    > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
    > > > >
    > > > > Bug: v8:10577
    > > > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
    > > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
    > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#68168}
    > > >
    > > > Bug: v8:10577
    > > > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
    > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
    > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#68989}
    > >
    > > Bug: v8:10577
    > > Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#69339}
    > 
    > Bug: v8:10577
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    > Change-Id: I4a69dc57a102782cb453144323e3752ac8278624
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69433}
    
    TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org
    
    Change-Id: I4ccdd7b931d0ddccbcec1d6cfae8d4874ee49cfc
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10577
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360414Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
    Commit-Queue: Francis McCabe <fgm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69438}
    a5756085
Name
Last commit
Last update
..
embenchen Loading commit data...
OWNERS Loading commit data...
adapter-frame.js Loading commit data...
add-getters.js Loading commit data...
anyfunc.js Loading commit data...
asm-wasm-copy.js Loading commit data...
asm-wasm-deopt.js Loading commit data...
asm-wasm-exception-in-tonumber.js Loading commit data...
asm-wasm-expr.js Loading commit data...
asm-wasm-f32.js Loading commit data...
asm-wasm-f64.js Loading commit data...
asm-wasm-heap.js Loading commit data...
asm-wasm-i32.js Loading commit data...
asm-wasm-imports.js Loading commit data...
asm-wasm-literals.js Loading commit data...
asm-wasm-math-intrinsic.js Loading commit data...
asm-wasm-memory.js Loading commit data...
asm-wasm-names.js Loading commit data...
asm-wasm-stack.js Loading commit data...
asm-wasm-stdlib.js Loading commit data...
asm-wasm-switch.js Loading commit data...
asm-wasm-u32.js Loading commit data...
asm-wasm.js Loading commit data...
asm-with-wasm-off.js Loading commit data...
async-compile.js Loading commit data...
atomics-non-shared.js Loading commit data...
atomics-stress.js Loading commit data...
atomics.js Loading commit data...
atomics64-stress.js Loading commit data...
bigint-i64-to-imported-js-func.js Loading commit data...
bigint.js Loading commit data...
bounds-check-64bit.js Loading commit data...
bounds-check-turbofan.js Loading commit data...
bulk-memory.js Loading commit data...
call-ref.js Loading commit data...
calls.js Loading commit data...
code-space-exhaustion.js Loading commit data...
compare-exchange-stress.js Loading commit data...
compare-exchange64-stress.js Loading commit data...
compilation-hints-async-compilation.js Loading commit data...
compilation-hints-decoder.js Loading commit data...
compilation-hints-ignored.js Loading commit data...
compilation-hints-lazy-validation.js Loading commit data...
compilation-hints-streaming-compilation.js Loading commit data...
compilation-hints-streaming-lazy-validation.js Loading commit data...
compilation-hints-sync-compilation.js Loading commit data...
compilation-limits-asm.js Loading commit data...
compilation-limits.js Loading commit data...
compiled-module-management.js Loading commit data...
compiled-module-serialization.js Loading commit data...
data-segments.js Loading commit data...
disable-trap-handler.js Loading commit data...
disallow-codegen.js Loading commit data...
divrem-trap.js Loading commit data...
empirical_max_memory.js Loading commit data...
ensure-wasm-binaries-up-to-date.js Loading commit data...
errors.js Loading commit data...
exceptions-export.js Loading commit data...
exceptions-externref.js Loading commit data...
exceptions-global.js Loading commit data...
exceptions-import.js Loading commit data...
exceptions-rethrow.js Loading commit data...
exceptions-shared.js Loading commit data...
exceptions-simd.js Loading commit data...
exceptions-utils.js Loading commit data...
exceptions.js Loading commit data...
export-global.js Loading commit data...
export-identity.js Loading commit data...
export-mutable-global.js Loading commit data...
export-table.js Loading commit data...
expose-wasm.js Loading commit data...
externref-globals.js Loading commit data...
externref-table.js Loading commit data...
externref.js Loading commit data...
ffi-error.js Loading commit data...
ffi.js Loading commit data...
float-constant-folding.js Loading commit data...
function-names.js Loading commit data...
function-prototype.js Loading commit data...
futex.js Loading commit data...
gc-buffer.js Loading commit data...
gc-frame.js Loading commit data...
gc-memory.js Loading commit data...
gc-stress.js Loading commit data...
generic-wrapper.js Loading commit data...
globals-import-export-identity.js Loading commit data...
globals.js Loading commit data...
graceful_shutdown.js Loading commit data...
graceful_shutdown_during_tierup.js Loading commit data...
grow-huge-memory.js Loading commit data...
grow-memory-detaching.js Loading commit data...
grow-memory-in-branch.js Loading commit data...
grow-memory-in-call.js Loading commit data...
grow-memory-in-loop.js Loading commit data...
grow-memory.js Loading commit data...
grow-shared-memory.js Loading commit data...
huge-memory.js Loading commit data...
huge-typedarray.js Loading commit data...
import-function.js Loading commit data...
import-memory.js Loading commit data...
import-mutable-global.js Loading commit data...
import-table.js Loading commit data...
incrementer.wasm Loading commit data...
indirect-call-non-zero-table.js Loading commit data...
indirect-calls.js Loading commit data...
indirect-sig-mismatch.js Loading commit data...
indirect-tables.js Loading commit data...
instance-gc.js Loading commit data...
instance-memory-gc-stress.js Loading commit data...
instantiate-module-basic.js Loading commit data...
instantiate-run-basic.js Loading commit data...
js-api.js Loading commit data...
large-offset.js Loading commit data...
lazy-compilation.js Loading commit data...
liftoff-simd-params.js Loading commit data...
liftoff-trap-handler.js Loading commit data...
liftoff.js Loading commit data...
loop-rotation.js Loading commit data...
many-modules.js Loading commit data...
many-parameters.js Loading commit data...
memory-external-call.js Loading commit data...
memory-instance-validation.js Loading commit data...
memory-size.js Loading commit data...
memory.js Loading commit data...
memory_1gb_oob.js Loading commit data...
memory_2gb_oob.js Loading commit data...
memory_4gb_oob.js Loading commit data...
module-memory.js Loading commit data...
multi-table-element-section.js Loading commit data...
multi-value.js Loading commit data...
multiple-code-spaces.js Loading commit data...
mutable-globals.js Loading commit data...
names.js Loading commit data...
origin-trial-flags.js Loading commit data...
parallel_compilation.js Loading commit data...
params.js Loading commit data...
print-code.js Loading commit data...
receiver.js Loading commit data...
return-calls.js Loading commit data...
serialize-lazy-module.js Loading commit data...
shared-arraybuffer-worker-simple-gc.js Loading commit data...
shared-memory-gc-stress.js Loading commit data...
shared-memory-worker-explicit-gc-stress.js Loading commit data...
shared-memory-worker-gc-stress.js Loading commit data...
shared-memory-worker-gc.js Loading commit data...
shared-memory-worker-simple-gc.js Loading commit data...
shared-memory-worker-stress.js Loading commit data...
shared-memory.js Loading commit data...
simd-call.js Loading commit data...
simd-errors.js Loading commit data...
simd-globals.js Loading commit data...
stack.js Loading commit data...
stackwalk.js Loading commit data...
start-function.js Loading commit data...
streaming-api.js Loading commit data...
streaming-compile.js Loading commit data...
streaming-error-position.js Loading commit data...
streaming-trap-location.js Loading commit data...
table-access.js Loading commit data...
table-copy-externref.js Loading commit data...
table-copy.js Loading commit data...
table-fill.js Loading commit data...
table-get.js Loading commit data...
table-grow-from-wasm.js Loading commit data...
table-grow.js Loading commit data...
table-limits.js Loading commit data...
table.js Loading commit data...
test-wasm-module-builder.js Loading commit data...
tier-down-to-liftoff.js Loading commit data...
tier-up-testing-flag.js Loading commit data...
trap-location.js Loading commit data...
type-reflection-with-exnref.js Loading commit data...
type-reflection-with-externref.js Loading commit data...
type-reflection-with-mv.js Loading commit data...
type-reflection.js Loading commit data...
typed-funcref.js Loading commit data...
unicode-validation.js Loading commit data...
unicode.js Loading commit data...
unreachable-validation.js Loading commit data...
unreachable.js Loading commit data...
user-properties-common.js Loading commit data...
user-properties-constructed.js Loading commit data...
user-properties-exported.js Loading commit data...
user-properties-module.js Loading commit data...
user-properties-reexport.js Loading commit data...
verify-module-basic-errors.js Loading commit data...
wasm-api-overloading.js Loading commit data...
wasm-default.js Loading commit data...
wasm-dynamic-tiering.js Loading commit data...
wasm-math-intrinsic.js Loading commit data...
wasm-module-builder.js Loading commit data...
wasm-object-api.js Loading commit data...
worker-memory.js Loading commit data...
worker-module.js Loading commit data...