• Maya Lekova's avatar
    Revert "cppgc: Rework GC info creation" · 8b9d0138
    Maya Lekova authored
    This reverts commit d76064df.
    
    Reason for revert: Breaking MSAN - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/37390/overview
    
    Original change's description:
    > cppgc: Rework GC info creation
    >
    > Previously, GCInfoTrait relied on the non-trivial constructor of a
    > static object for registering a new GCInfo object. The generated code
    > is required to be thread-safe which is achieved by introducing guard
    > variables in the compiler.
    >
    > The new version is similar to Blink in that it relies on zero
    > initialization of a trivially constructible atomic.
    >
    > Compared to guard variables that are created per GCInfo registration,
    > the atomic creates less bloat (~20bytes/type) and also results in a
    > better fast path.
    >
    > Minimum example: https://godbolt.org/z/qrdTf8
    >
    > Bug: chromium:1056170
    > Change-Id: I95efbbf035b655d0440c9477f5391e310e2b71fa
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764750
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73463}
    
    Bug: chromium:1056170
    Change-Id: I71960103513d6db7789d752b70727d014c2e6406
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767020
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73466}
    8b9d0138
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...