• Francis McCabe's avatar
    Revert "[wasm-simd][ia32][x64] Only use registers for shuffles" · a308d3fe
    Francis McCabe authored
    This reverts commit 3fb07882.
    
    Reason for revert: failing noavx tests:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/39390?
    
    
    Original change's description:
    > [wasm-simd][ia32][x64] Only use registers for shuffles
    >
    > Shuffles have pattern matching clauses which, depending on the
    > instruction used, can require src0 or src1 to be register or not.
    > However we do not have 16-byte alignment for SIMD operands yet, so it
    > will segfault when we use an SSE SIMD instruction with unaligned
    > operands.
    >
    > This patch fixes all the shuffle cases to always use a register for the
    > input nodes, and it does so by ignoring the values of src0_needs_reg and
    > src1_needs_reg. When we eventually have memory alignment, we can
    > re-enable this check, without mucking around too much in the logic in
    > each shuffle match clause.
    >
    > Bug: v8:9198
    > Change-Id: I264e136f017353019f19954c62c88206f7b90656
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504849
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Commit-Queue: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70848}
    
    TBR=adamk@chromium.org,ahaas@chromium.org,zhin@chromium.org
    
    Change-Id: Icc7cc1ceb7ca5aa5d859239330743dde2e5f213c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9198
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505719Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
    Commit-Queue: Francis McCabe <fgm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70852}
    a308d3fe
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...