• wingo@igalia.com's avatar
    Allocate generator result objects before unwinding try handlers · 418ddc80
    wingo@igalia.com authored
    When a generator suspends, it saves its state out to the heap and
    unwinds try handlers but doesn't pop anything off the stack.  Instead it
    relies on no GC happening between the suspend and the return from the
    generator.  However this was not the case: boxing the result object
    could cause GC, which would try to traverse the stack but would
    misinterpret words from unwound try handlers as heap objects.
    
    This CL changes to allocate the result objects before the suspend.  It
    also removes the generators-iteration skip introduced in r15065.
    
    R=mstarzinger@chromium.org
    TEST=mjsunit/harmony/generators-iteration
    BUG=
    
    Review URL: https://codereview.chromium.org/16801006
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    418ddc80
Name
Last commit
Last update
..
assembler-x64-inl.h Loading commit data...
assembler-x64.cc Loading commit data...
assembler-x64.h Loading commit data...
builtins-x64.cc Loading commit data...
code-stubs-x64.cc Loading commit data...
code-stubs-x64.h Loading commit data...
codegen-x64.cc Loading commit data...
codegen-x64.h Loading commit data...
cpu-x64.cc Loading commit data...
debug-x64.cc Loading commit data...
deoptimizer-x64.cc Loading commit data...
disasm-x64.cc Loading commit data...
frames-x64.cc Loading commit data...
frames-x64.h Loading commit data...
full-codegen-x64.cc Loading commit data...
ic-x64.cc Loading commit data...
lithium-codegen-x64.cc Loading commit data...
lithium-codegen-x64.h Loading commit data...
lithium-gap-resolver-x64.cc Loading commit data...
lithium-gap-resolver-x64.h Loading commit data...
lithium-x64.cc Loading commit data...
lithium-x64.h Loading commit data...
macro-assembler-x64.cc Loading commit data...
macro-assembler-x64.h Loading commit data...
regexp-macro-assembler-x64.cc Loading commit data...
regexp-macro-assembler-x64.h Loading commit data...
simulator-x64.cc Loading commit data...
simulator-x64.h Loading commit data...
stub-cache-x64.cc Loading commit data...