• Manos Koukoutos's avatar
    [wasm-gc][bug] Fix signature canonicalization · 4d9d8518
    Manos Koukoutos authored
    We used not to emit canonical indexes for arrays and structs into
    WasmModule::signature_ids, which resulted in signature_ids not referring
    to the correct type indices in a WasmModule.
    
    Changes:
    - Rename signature_ids to canonical_type_ids.
    - Emit trivial canonical type ids for structs and arrays.
    - Add a test to catch the existing bug.
    - Improve DCHECKs for module type accessors.
    
    Bug: v8:7748
    Change-Id: I67ad58865e35b459b21db12557564b652035db75
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444989
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70318}
    4d9d8518
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...