-
Santiago Aboy Solanes authored
Wasm has the attribute sourceLineToBytecodePosition and adds the source lines via setSourceLineToBytecodePosition in which they are 0-based. Non-Wasm doesn't have that attribute and uses insertSourcePositions which is 1-based. In non-wasm we are being off by one. As a note, the sourcePositionsInRange call in insertSourcePositions doesn't return a list for Wasm since they rely on setSourceLineToBytecodePosition and therefore do not have that off-by-one error. Drive-by: Several elements have the same source position so update addHtmlElementToSourcePosition to handle more than one element. Drive-by: Renames due to having the same name but different capitalization, which was confusing. Bug: v8:7327 Change-Id: Ie8a066ca629054a5f5a754deec0ed1917bed2b33 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008634Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75655}
433ff6b9
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
img | Loading commit data... | |
src | ||
test | ||
OWNERS | ||
README.md | ||
deploy.sh | ||
down-arrow.png | ||
index.html | ||
info-view.html | ||
left-arrow.png | ||
package-lock.json | ||
package.json | ||
right-arrow.png | ||
rollup.config.js | ||
search2.png | ||
tabs.css | ||
tsconfig.json | ||
tsconfig.test.json | ||
tsfmt.json | ||
tslint.json | ||
turbo-visualizer-ranges.css | ||
turbo-visualizer.css | ||
turbolizer.png | ||
up-arrow.png | ||
upload-icon.png |