• Ulan Degenbaev's avatar
    Revert "Reland x5 [arraybuffer] Rearchitect backing store ownership" · 9da34831
    Ulan Degenbaev authored
    This reverts commit 62e16830.
    
    Reason for revert: it will be relanded after branch
    
    Original change's description:
    > Reland x5 [arraybuffer] Rearchitect backing store ownership
    > 
    > This reverts commit 8fdb2387.
    > 
    > Original change's description:
    > > "Reland x4 [arraybuffer] Rearchitect backing store ownership"
    > >
    > > This is a reland of bc33f5ae
    > >
    > > Contributed by titzer@chromium.org
    > >
    > > Original change's description:
    > > > [arraybuffer] Rearchitect backing store ownership
    > > >
    > > > This CL completely rearchitects the ownership of array buffer backing stores,
    > > > consolidating ownership into a {BackingStore} C++ object that is tracked
    > > > throughout V8 using unique_ptr and shared_ptr where appropriate.
    > > >
    > > > Overall, lifetime management is simpler and more explicit. The numerous
    > > > ways that array buffers were initialized have been streamlined to one
    > > > Attach() method on JSArrayBuffer. The array buffer tracker in the
    > > > GC implementation now manages std::shared_ptr<BackingStore> pointers,
    > > > and the construction and destruction of the BackingStore object itself
    > > > handles the underlying page or embedder-allocated memory.
    > > >
    > > > The embedder API remains unchanged for now. We use the
    > > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to
    > > > keep the backing store alive properly, even in the case of aliases
    > > > from live heap objects. Thus the embedder has a lower chance of making
    > > > a mistake. Long-term, we should move the embedder to a model where they
    > > > manage backing stores using shared_ptr to an opaque backing store object.
    > >
    > > TBR=yangguo@chromium.org
    > >
    > > BUG=v8:9380,v8:9221,chromium:986318
    > >
    > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005
    > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#63041}
    > 
    > TBR=yangguo@chromium.org,clemensh@chromium.org,mstarzinger@chromium.org
    > 
    > Change-Id: Iba55c7ab71e5642b5cb6aeb699d6fc9cf9061486
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771795
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63461}
    
    TBR=ulan@chromium.org,mlippautz@chromium.org
    
    Change-Id: Id8f67a68ab398032eb2975b1b24ee125394d9c4b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776095Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63471}
    9da34831
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...