• Ng Zhi An's avatar
    [wasm-simd] Fix f64x2 replace lane · f3cbcdb2
    Ng Zhi An authored
    There are a couple of bugs here:
    
    1. The immediate used for vinsertps is wrong when lane == 1, the first
    two bits specify which element of the source is copied, and it should
    always be 00, 01 to copy the first 2 lanes of source.
    2. For both cases, the second insertps call should be using dst as the
    src, since dst was already updated by the first insertps call, it was
    incorrectly using the old value of src. This was probably working
    correctly because in many cases dst and src happened to be the same
    register.
    3. rep cannot be same as dst, because dst is overwritten, and rep should
    stay the same
    
    I also modified the F64x2ReplaceLane to test separately for replacing
    lane 0 and lane 1.
    
    Fixed bug 3. for arm and arm64.
    
    Bug: v8:9728
    Change-Id: Iec6e48bcfbc7d27908dd86d5f113a8b5dedd499b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877055Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64620}
    f3cbcdb2
Name
Last commit
Last update
..
OWNERS Loading commit data...
test-c-wasm-entry.cc Loading commit data...
test-grow-memory.cc Loading commit data...
test-jump-table-assembler.cc Loading commit data...
test-run-wasm-64.cc Loading commit data...
test-run-wasm-asmjs.cc Loading commit data...
test-run-wasm-atomics.cc Loading commit data...
test-run-wasm-atomics64.cc Loading commit data...
test-run-wasm-bulk-memory.cc Loading commit data...
test-run-wasm-exceptions.cc Loading commit data...
test-run-wasm-interpreter.cc Loading commit data...
test-run-wasm-js.cc Loading commit data...
test-run-wasm-module.cc Loading commit data...
test-run-wasm-sign-extension.cc Loading commit data...
test-run-wasm-simd.cc Loading commit data...
test-run-wasm.cc Loading commit data...
test-streaming-compilation.cc Loading commit data...
test-wasm-breakpoints.cc Loading commit data...
test-wasm-codegen.cc Loading commit data...
test-wasm-import-wrapper-cache.cc Loading commit data...
test-wasm-interpreter-entry.cc Loading commit data...
test-wasm-serialization.cc Loading commit data...
test-wasm-shared-engine.cc Loading commit data...
test-wasm-stack.cc Loading commit data...
test-wasm-trap-position.cc Loading commit data...
wasm-atomics-utils.h Loading commit data...
wasm-run-utils.cc Loading commit data...
wasm-run-utils.h Loading commit data...