• adamk's avatar
    [modules] Store Module metadata in per-Context EmbedderData · 9d2051fc
    adamk authored
    This is a re-land of https://codereview.chromium.org/2393303002/ with
    an additional call to DisposeModuleEmbedderData() added to fix lsan failures.
    
    Unifies the approaches used for storing the specifier -> module mapping
    and the module -> directory mapping, using std::unordered_maps for both
    and storing them per-Context.
    
    This requires adding a method to the v8::Module API to get a hash code
    for a Module, but allows slimming down the API in return: gone are
    SetEmbedderData/GetEmbedderData, along with the fourth argument
    to ResolveModuleCallback.
    
    Besides a simpler API, this allows d8 to get closer to the HTML loader,
    which requires each Realm to have a persistent module map (though this
    capability is not yet exercised by any tests).
    
    BUG=v8:1569
    TBR=neis@chromium.org,jochen@chromium.org
    
    Review-Url: https://codereview.chromium.org/2405313002
    Cr-Commit-Position: refs/heads/master@{#40186}
    9d2051fc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...